[MediaWiki-commits] [Gerrit] fixing issues of jshint - change (mediawiki...LanguageTool)

[Eranroz (Code Review)]

Eranroz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/222759

Change subject: fixing issues of jshint
......................................................................

fixing issues of jshint

Change-Id: Ia5c35a19cd8d9fd8b7e98b6d86016c66dc3e6a52
---
M modules/ext.LanguageToolAction.js
M package.json
2 files changed, 23 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LanguageTool 
refs/changes/59/222759/1

diff --git a/modules/ext.LanguageToolAction.js 
b/modules/ext.LanguageToolAction.js
index 25659f1..6c98804 100644
--- a/modules/ext.LanguageToolAction.js
+++ b/modules/ext.LanguageToolAction.js
@@ -50,7 +50,7 @@
                var i;
 
                for ( i = 0; i < obj.children.length; i++ ) {
-                       if ( obj.children[i].type === 'text'){
+                       if ( obj.children[i].type === 'text') {
                                nodes.push(obj.children[i]);
                        }
 
@@ -70,23 +70,25 @@
  * @return {NULL} Action was executed
  */
 mw.languageToolAction.prototype.send = function () {
-       var textNodes = this.extract();
-       var model = ve.init.target.getSurface().getModel();
-       var text = "";
-       for (var nodeI = 0; nodeI < textNodes.length; nodeI++) {
-               var node = textNodes[nodeI];
-               var nodeRange = node.getRange();
-               var nodeText = model.getLinearFragment(nodeRange).getText();
-               text = text + "\n" + nodeText;
+       var textNodes = this.extract(),
+               model = ve.init.target.getSurface().getModel(),
+               text = '',
+               lang = mw.config.get( 'wgPageContentLanguage' ),
+               nodeI, node, nodeRange, nodeText;
+
+       for (nodeI = 0; nodeI < textNodes.length; nodeI++) {
+               node = textNodes[nodeI],
+               nodeRange = node.getRange(),
+               nodeText = model.getLinearFragment(nodeRange).getText();
+               text = text + '\n' + nodeText;
        }
-       var lang = mw.config.get( 'wgPageContentLanguage' );
 
        $.ajax(
        {
                type: 'POST',
-               //dataType: 'xml',
+               // dataType: 'xml',
                url: 'http://tools.wmflabs.org/languageproofing/',
-               data: {language: lang,  text: text}
+               data: { language: lang,  text: text }
        }
        )
        .done( this.openDialog );
@@ -94,21 +96,20 @@
 };
 
 mw.languageToolAction.prototype.openDialog = function ( responseXML ) {
-       var messageDialog = new OO.ui.MessageDialog();
+       var messageDialog = new OO.ui.MessageDialog(),
+               windowManager = new OO.ui.WindowManager(), // Create and append 
a window manager.
+               errors = responseXML.getElementsByTagName( 'error' ),
+               response = '',
+               i;
 
-       // Create and append a window manager.
-       var windowManager = new OO.ui.WindowManager();
        $( 'body' ).append( windowManager.$element );
        windowManager.addWindows( [ messageDialog ] );
 
-       var errors = responseXML.getElementsByTagName( "error" );
        console.log(errors);
-       var i;
-       var response = "";
        for ( i = 0; i < errors.length; i++ ) {
-               response = response + "ERROR " + i + " :\n";
-               response = response + "error : " + errors[i].getAttribute( 
'msg' ) + "\n";
-               response = response + "context : " + errors[i].getAttribute( 
'context' ) + "\n";
+               response = response + 'ERROR ' + i + ' :\n';
+               response = response + 'error : ' + errors[i].getAttribute( 
'msg' ) + '\n';
+               response = response + 'context : ' + errors[i].getAttribute( 
'context' ) + '\n';
                messageDialog.setData( 'error', errors[i].getAttribute( 'msg' ) 
);
                messageDialog.setData( 'context', errors[i].getAttribute( 
'context' ));
        }
diff --git a/package.json b/package.json
index a1bfe51..3613055 100644
--- a/package.json
+++ b/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "boilerplate",
+  "name": "LanguageTool",
   "version": "0.0.0",
   "scripts": {
     "test": "grunt test"

-- 
To view, visit https://gerrit.wikimedia.org/r/222759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5c35a19cd8d9fd8b7e98b6d86016c66dc3e6a52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Eranroz <eranro...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits