Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222856
Change subject: Remove B/C hack when modifyEntity would return true
......................................................................
Remove B/C hack when modifyEntity would return true
After looking at all implementations of the modifyEntity
method none will ever return true now.
Change-Id: Ifaf74f61887af1fbad59ef5f2700d21f416fa6a6
---
M repo/includes/api/ModifyEntity.php
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/56/222856/1
diff --git a/repo/includes/api/ModifyEntity.php
b/repo/includes/api/ModifyEntity.php
index 4ff37a3..8acd776 100644
--- a/repo/includes/api/ModifyEntity.php
+++ b/repo/includes/api/ModifyEntity.php
@@ -353,10 +353,6 @@
$this->dieError( 'Attempted modification of the item
failed', 'failed-modify' );
}
- if ( $summary === true ) { // B/C, for implementations of
modifyEntity that return true on success.
- $summary = new Summary( $this->getModuleName() );
- }
-
$this->addFlags( $entity->getId() === null );
//NOTE: EDIT_NEW will not be set automatically. If the entity
doesn't exist, and EDIT_NEW was
--
To view, visit https://gerrit.wikimedia.org/r/222856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifaf74f61887af1fbad59ef5f2700d21f416fa6a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
