jenkins-bot has submitted this change and it was merged.
Change subject: Regression: correctly position the
.collection-confirmation-overlay
......................................................................
Regression: correctly position the .collection-confirmation-overlay
* .content-overlay does not center the content when position: fixed is
applied to it. Add left and right values to
.collection-confirmation-overlay so that its content is aligned in the
center of the page. The 3% values are consistent with the values of
other overlays.
* Set the max-width equal to 500px to be consistent with
.collection-overlay
Bug: T104692
Change-Id: I02c7f1d918af1d9bb194ef225c223462b92634fd
---
M resources/ext.gather.collection.confirm/confirmationOverlay.less
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.gather.collection.confirm/confirmationOverlay.less
b/resources/ext.gather.collection.confirm/confirmationOverlay.less
index 5d1f744..c825c3d 100644
--- a/resources/ext.gather.collection.confirm/confirmationOverlay.less
+++ b/resources/ext.gather.collection.confirm/confirmationOverlay.less
@@ -6,6 +6,13 @@
text-align: center;
z-index: @z-indexOverOverlay;
+ &.position-fixed {
+ left: 3%;
+ right: 3%;
+ margin: 0 auto;
+ max-width: 500px;
+ }
+
h3 {
padding: 0.25em;
}
@@ -19,6 +26,7 @@
padding: 0.5em;
}
+ // FIXME: no need for this selector, merge the contents with the above
rules
&.content-overlay {
background-color: white;
top: @headerHeight * 1.2;
--
To view, visit https://gerrit.wikimedia.org/r/222568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02c7f1d918af1d9bb194ef225c223462b92634fd
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: BarryTheBrowserTestBot <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
