Kaldari has submitted this change and it was merged.
Change subject: (bug 41866) Fix invalid notification in the flyout and page
......................................................................
(bug 41866) Fix invalid notification in the flyout and page
1. Skip invalid notification events
2. Add formatting to notifcation count, for example, if the count is over 99,
we just show 99+
patch set 2:
* fix trailing whitespace
patch set 3:
* remove extra whitespace and indentation
patch set 4:
* change function name from gatherValidEchoEvent() to
gatherValidEchoEvents()
* add more descriptive documentation
Change-Id: I81a135c24f64fa1aace4dd2631e9b88bbe22d3d0
---
M Echo.i18n.php
M Echo.php
M Hooks.php
M api/ApiEchoNotifications.php
M controller/NotificationController.php
M model/Event.php
M special/SpecialNotifications.php
7 files changed, 102 insertions(+), 19 deletions(-)
Approvals:
Kaldari: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/33290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a135c24f64fa1aace4dd2631e9b88bbe22d3d0
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
