Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223065
Change subject: WikidataPageBanner allow custom Wikidata Banner
......................................................................
WikidataPageBanner allow custom Wikidata Banner
If {{PAGEBANNER}} provides an invalid bannername, it should attempt to load a
Wikidata Banner there itself.
Bug: T104886
Change-Id: Ifa58bbb631d968d61c7bad52d7e327dcec54df2b
---
M includes/WikidataPageBanner.hooks.php
M tests/phpunit/BannerTest.php
2 files changed, 6 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/65/223065/1
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 1f32fb9..45380c8 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -121,7 +121,11 @@
$banner = static::getBannerHtml( $bannername,
$paramsForBannerTemplate );
// if given banner does not exist, return
if ( $banner === null ) {
- return array( '', 'noparse' => true, 'isHTML'
=> true );
+ $bannername = static::getWikidataBanner( $title
);
+ $banner = static::getBannerHtml( $bannername,
$paramsForBannerTemplate );
+ if ( $banner === null ) {
+ return array( '', 'noparse' => true,
'isHTML' => true );
+ }
}
// Set 'articlebanner' property for future reference
$parser->getOutput()->setProperty( 'articlebanner',
$banner );
diff --git a/tests/phpunit/BannerTest.php b/tests/phpunit/BannerTest.php
index 2a3832c..53951a9 100644
--- a/tests/phpunit/BannerTest.php
+++ b/tests/phpunit/BannerTest.php
@@ -43,7 +43,7 @@
protected $testPagesForCustomBanner = array(
array( 'PageWithCustomBanner', NS_MAIN, "Banner" ),
array( 'PageInTalkNamespace', NS_TALK, '' ),
- array( 'NoBanner', NS_MAIN, '' )
+ array( 'NoBanner', NS_MAIN, "Banner" )
);
/**
--
To view, visit https://gerrit.wikimedia.org/r/223065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa58bbb631d968d61c7bad52d7e327dcec54df2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
