jenkins-bot has submitted this change and it was merged. Change subject: Add IContextSource $context = null in WikibaseRepo ......................................................................
Add IContextSource $context = null in WikibaseRepo This brings recently added methods in line with the rest of WikibaseRepo, where $context is optional to avoid making various things overly complex. I am aware there is optional hidden global state here, but this should be fixed in a seperate patch as it would require touching lots of places. Once the hiding of global state in various places is fixed and they rewuire context to be passed down then the can and should explicetly require context at this higher level. See also: https://gerrit.wikimedia.org/r/#/c/223254/ https://gerrit.wikimedia.org/r/#/c/223262/ Change-Id: I677adb388d09b16e399734cab2f66f69c8a379ff --- M repo/includes/WikibaseRepo.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Bene: Looks good to me, approved Thiemo Mättig (WMDE): Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php index 3db405a..0f33a75 100644 --- a/repo/includes/WikibaseRepo.php +++ b/repo/includes/WikibaseRepo.php @@ -1070,11 +1070,11 @@ } /** - * @param IContextSource $context + * @param IContextSource|null $context * * @return ApiHelperFactory */ - public function getApiHelperFactory( $context ) { + public function getApiHelperFactory( IContextSource $context = null ) { return new ApiHelperFactory( $this->getEntityTitleLookup(), $this->getExceptionLocalizer(), @@ -1091,7 +1091,7 @@ * * @return EditEntityFactory */ - public function newEditEntityFactory( $context = null ) { + public function newEditEntityFactory( IContextSource $context = null ) { return new EditEntityFactory( $this->getEntityTitleLookup(), $this->getEntityRevisionLookup( 'uncached' ), -- To view, visit https://gerrit.wikimedia.org/r/223268 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I677adb388d09b16e399734cab2f66f69c8a379ff Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Bene <benestar.wikime...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
