[MediaWiki-commits] [Gerrit] Use for options parameter in wbparsevalue API - change (mediawiki...Wikibase)</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=mediawiki-commits@lists.wikimedia.org&q=from:%22jenkins%5C-bot+%5C%28Code+Review%5C%29%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">jenkins-bot (Code Review)</span></span></a></span> <span class="date"><a href="/search?l=mediawiki-commits@lists.wikimedia.org&q=date:20150707" rel="nofollow">Tue, 07 Jul 2015 05:09:14 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre>jenkins-bot has submitted this change and it was merged. Change subject: Use <textarea> for options parameter in wbparsevalue API ......................................................................</pre><pre> Use <textarea> for options parameter in wbparsevalue API The similar 'options' parameter in wbformatvalue is already a 'text' parameter now. The only difference between 'string' and 'text' is that the later is rendered as a <textarea> in the API sandbox. Change-Id: I7273afe1cfdb15753c8a23e70c2d1ff6abf5235d --- M repo/includes/api/ParseValue.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/repo/includes/api/ParseValue.php b/repo/includes/api/ParseValue.php index 98f2492..bc06493 100644 --- a/repo/includes/api/ParseValue.php +++ b/repo/includes/api/ParseValue.php @@ -219,7 +219,7 @@ ApiBase::PARAM_ISMULTI => true, ), 'options' => array( - ApiBase::PARAM_TYPE => 'string', + ApiBase::PARAM_TYPE => 'text', ApiBase::PARAM_REQUIRED => false, ), ); -- To view, visit <a rel="nofollow" href="https://gerrit.wikimedia.org/r/223257">https://gerrit.wikimedia.org/r/223257</a> To unsubscribe, visit <a rel="nofollow" href="https://gerrit.wikimedia.org/r/settings">https://gerrit.wikimedia.org/r/settings</a> Gerrit-MessageType: merged Gerrit-Change-Id: I7273afe1cfdb15753c8a23e70c2d1ff6abf5235d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org <a rel="nofollow" href="https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits">https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg271603.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd4.html#271637">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="mail4.html#271637">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg271605.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg271603.html">[MediaWiki-commits] [Gerrit] Use <textarea>...</a></span> <span class="sender italic">WMDE</span></li> <li><ul> <li class="icons-email tSliceCur"><span class="subject">[MediaWiki-commits] [Gerrit] Use <textar...</span> <span class="sender italic">jenkins-bot (Code Review)</span></li> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[MediaWiki-commits] [Gerrit] Use <textarea> for options parameter in wbparsevalue API - change (mediawiki...Wikibase)"> <input type="hidden" name="msgid" value="E1ZCRfz-00040m-Ja@polonium.wikimedia.org"> <input type="hidden" name="relpath" value="mediawiki-commits@lists.wikimedia.org/msg271637.html"> <input type="submit" value=" jenkins-bot (Code Review) "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="mediawiki-commits@lists.wikimedia.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search mediawiki-commits"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/mediawiki-commits@lists.wikimedia.org/">mediawiki-commits - all messages</a></li> <li class="icons-about"><a href="/mediawiki-commits@lists.wikimedia.org/info.html">mediawiki-commits - about the list</a></li> <li class="icons-expand"><a href="/search?l=mediawiki-commits@lists.wikimedia.org&q=subject:%22%5C%5BMediaWiki%5C-commits%5C%5D+%5C%5BGerrit%5C%5D+Use+%3Ctextarea%3E+for+options+parameter%09in+wbparsevalue+API+%5C-+change+%5C%28mediawiki...Wikibase%5C%29%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg271603.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg271605.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">E1ZCRfz-00040m-Ja@polonium.wikimedia.org</li> </ul> </div> </body> </html>