Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223288
Change subject: Disallow qqq as interface language
......................................................................
Disallow qqq as interface language
Any page on translatewiki with param setlang=qqq times. All messages
get parsed recursively until parser-template-loop-warning is reached.
uselang=qqq is already ignored, see RequestContext::sanitizeLangCode.
There is a counterpart to this patch in ULS, where it is changed
to use Language::isSupportedLanguage.
Bug: T104987
Change-Id: Ie77fe18681dfd5f9089fbaa8090dd9cc1c206da4
---
M languages/Language.php
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/88/223288/1
diff --git a/languages/Language.php b/languages/Language.php
index fe0bd7e..18442b3 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -254,10 +254,16 @@
* @since 1.21
*/
public static function isSupportedLanguage( $code ) {
- return self::isValidBuiltInCode( $code )
- && ( is_readable( self::getMessagesFileName( $code ) )
- || is_readable( self::getJsonMessagesFileName(
$code ) )
- );
+ if ( !self::isValidBuiltInCode( $code ) ) {
+ return false;
+ }
+
+ if ( $code === 'qqq' ) {
+ #return false;
+ }
+
+ return is_readable( self::getMessagesFileName( $code ) ) ||
+ is_readable( self::getJsonMessagesFileName( $code ) );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/223288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie77fe18681dfd5f9089fbaa8090dd9cc1c206da4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
