Manybubbles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223329
Change subject: Fix expected failure in smoke tests
......................................................................
Fix expected failure in smoke tests
We were using the wrong name for the search input field and not finding it.
Oops.
Change-Id: Iac2a819cb972385b95f0b40dbda8b6bd47993015
---
M tests/browser/features/smoke.feature
M tests/browser/features/support/pages/search_results_page.rb
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/29/223329/1
diff --git a/tests/browser/features/smoke.feature
b/tests/browser/features/smoke.feature
index 82c128f..f0a687e 100644
--- a/tests/browser/features/smoke.feature
+++ b/tests/browser/features/smoke.feature
@@ -18,7 +18,6 @@
Then a list of suggested pages should appear
And Main Page should be the first result
- @expect_failure
Scenario: Fill in search term and click search
Given I am at a random page
When I search for: ma
diff --git a/tests/browser/features/support/pages/search_results_page.rb
b/tests/browser/features/support/pages/search_results_page.rb
index 3dcde42..6ae1988 100644
--- a/tests/browser/features/support/pages/search_results_page.rb
+++ b/tests/browser/features/support/pages/search_results_page.rb
@@ -4,7 +4,7 @@
page_url URL.url("/w/index.php?search=<%=params[:search]%><%if
(params[:prefix]) %>&prefix=<%=params[:prefix]%><% end %>")
- text_field(:search, css: "#searchText input")
+ text_field(:search, css: "#searchText")
h1(:title, id: "firstHeading")
unordered_list(:search_results, class: "mw-search-results")
li(:first_result_wrapper) { |page|
page.search_results_element.list_item_element(index: 0) }
--
To view, visit https://gerrit.wikimedia.org/r/223329
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac2a819cb972385b95f0b40dbda8b6bd47993015
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Manybubbles <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
