Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223479
Change subject: HTMLTextAreaField: Honor 'rows' setting in OOUI format
......................................................................
HTMLTextAreaField: Honor 'rows' setting in OOUI format
And throw an exception if 'cols' is set, since it won't work.
Requires eed0f5294b0080 in OOUI.
Bug: T104682
Change-Id: I8e09402a01cecac8a90497d31b3b1ca15ff2d949
---
M includes/htmlform/HTMLTextAreaField.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/79/223479/1
diff --git a/includes/htmlform/HTMLTextAreaField.php
b/includes/htmlform/HTMLTextAreaField.php
index e4f78b2..aeb4b7c 100644
--- a/includes/htmlform/HTMLTextAreaField.php
+++ b/includes/htmlform/HTMLTextAreaField.php
@@ -47,6 +47,10 @@
}
function getInputOOUI( $value ) {
+ if ( isset( $this->mParams['cols'] ) ) {
+ throw new Exception( "OOUIHTMLForm does not support the
'cols' parameter for textareas" );
+ }
+
$attribs = $this->getTooltipAndAccessKey();
if ( $this->mClass !== '' ) {
@@ -72,6 +76,7 @@
'name' => $this->mName,
'multiline' => true,
'value' => $value,
+ 'rows' => $this->getRows(),
) + $attribs );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/223479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e09402a01cecac8a90497d31b3b1ca15ff2d949
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
