jenkins-bot has submitted this change and it was merged.
Change subject: Don't show select and share tips on Gingerbread
......................................................................
Don't show select and share tips on Gingerbread
Gingerbread doesn't support long press in its WebView. Don't show
impossible tips.
Change-Id: If094a95f8ac726f4918ba127d137d410cf70a057
---
M wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
index 684fe39..e6910a5 100644
--- a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
+++ b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
@@ -455,11 +455,16 @@
}
public boolean isFeatureSelectTextAndShareTutorialEnabled() {
- if (Prefs.hasFeatureSelectTextAndShareTutorial()) {
- return Prefs.isFeatureSelectTextAndShareTutorialEnabled();
+ boolean enabled = false;
+ // Select text does not work on Gingerbread.
+ if (ApiUtil.hasHoneyComb()) {
+ if (Prefs.hasFeatureSelectTextAndShareTutorial()) {
+ enabled = Prefs.isFeatureSelectTextAndShareTutorialEnabled();
+ } else {
+ enabled = new Random().nextInt(2) == 0;
+ Prefs.setFeatureSelectTextAndShareTutorialEnabled(enabled);
+ }
}
- boolean enabled = new Random().nextInt(2) == 0;
- Prefs.setFeatureSelectTextAndShareTutorialEnabled(enabled);
return enabled;
}
--
To view, visit https://gerrit.wikimedia.org/r/223502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If094a95f8ac726f4918ba127d137d410cf70a057
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
