jenkins-bot has submitted this change and it was merged. Change subject: Revert "Make toolbar save button frameless" ......................................................................
Revert "Make toolbar save button frameless" This reverts commit cb11cbd2f5e3dd09c5af8ca0cc19b3071ec63f9a. Actually not needed after 3d36cac7fc4808f708f03b66f5c099de440e4569 in OOjs UI, and would change the UI in unexpected way. Bug: T103403 Change-Id: Ia30b168ea29d03aa76ad81d1f9894a67604fdc08 --- M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js index 019477f..deeb0d2 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js @@ -1195,7 +1195,6 @@ ve.init.mw.ViewPageTarget.prototype.setupToolbarSaveButton = function () { this.toolbarSaveButton = new OO.ui.ButtonWidget( { label: ve.msg( 'visualeditor-toolbar-savedialog' ), - framed: false, flags: [ 'progressive', 'primary' ], disabled: !this.restoring } ); -- To view, visit https://gerrit.wikimedia.org/r/223300 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia30b168ea29d03aa76ad81d1f9894a67604fdc08 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits