Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223746
Change subject: Fix blurry banners when no support for srcset
......................................................................
Fix blurry banners when no support for srcset
Set src attribute of banner image to url of largest in order to load best
banner when browser has no support for srcset.
Bug: T105203
Change-Id: I0b659b30b89171a91c70b0e243accf7f0046d1b6
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/46/223746/1
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 29e57c7..9d8a02a 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -195,7 +195,7 @@
}
// create full src set from individual urls, separated
by comma
$srcset = implode( ',', $srcset );
- $bannerurl = $urls[0];
+ $bannerurl = $urls[count($urls) - 1];
$bannerfile = str_replace( "$1", "File:$bannername",
$wgArticlePath );
$templateParser = new TemplateParser( __DIR__ .
'/../templates' );
$options['bannerfile'] = $bannerfile;
--
To view, visit https://gerrit.wikimedia.org/r/223746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b659b30b89171a91c70b0e243accf7f0046d1b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
