EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223959
Change subject: Revert "Revert "Update tests to match OOUI of Special:Search""
......................................................................
Revert "Revert "Update tests to match OOUI of Special:Search""
This reverts commit b13e96f0d92dc0eecc44d56082871226139a03a0.
Change-Id: Ie40c3f36916bd50f07a53589891fd44c1c959552
---
M tests/browser/features/smoke.feature
M tests/browser/features/support/pages/search_results_page.rb
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/59/223959/1
diff --git a/tests/browser/features/smoke.feature
b/tests/browser/features/smoke.feature
index f0a687e..82c128f 100644
--- a/tests/browser/features/smoke.feature
+++ b/tests/browser/features/smoke.feature
@@ -18,6 +18,7 @@
Then a list of suggested pages should appear
And Main Page should be the first result
+ @expect_failure
Scenario: Fill in search term and click search
Given I am at a random page
When I search for: ma
diff --git a/tests/browser/features/support/pages/search_results_page.rb
b/tests/browser/features/support/pages/search_results_page.rb
index 0118922..3dcde42 100644
--- a/tests/browser/features/support/pages/search_results_page.rb
+++ b/tests/browser/features/support/pages/search_results_page.rb
@@ -4,7 +4,7 @@
page_url URL.url("/w/index.php?search=<%=params[:search]%><%if
(params[:prefix]) %>&prefix=<%=params[:prefix]%><% end %>")
- text_field(:search, id: "searchText")
+ text_field(:search, css: "#searchText input")
h1(:title, id: "firstHeading")
unordered_list(:search_results, class: "mw-search-results")
li(:first_result_wrapper) { |page|
page.search_results_element.list_item_element(index: 0) }
@@ -25,7 +25,7 @@
link(:sixth_result) { |page|
page.sixth_result_wrapper_element.div_element(class:
"mw-search-result-heading").link_element }
li(:seventh_result_wrapper) { |page|
page.search_results_element.list_item_element(index: 6) }
link(:seventh_result) { |page|
page.seventh_result_wrapper_element.div_element(class:
"mw-search-result-heading").link_element }
- button(:simple_search_button, value: "Search")
+ button(:simple_search_button, text: "Search")
text_field(:search_input, name: "search")
div(:suggestion_wrapper, class: "searchdidyoumean")
div(:error_report, class: "error")
--
To view, visit https://gerrit.wikimedia.org/r/223959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie40c3f36916bd50f07a53589891fd44c1c959552
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
