Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223987
Change subject: Hygiene: reorder dev settings & suppress bad warns
......................................................................
Hygiene: reorder dev settings & suppress bad warns
- Add A/B feature testing section and reorder developer settings.
- Ignore invalid style usage warnings in developer settings XML.
Change-Id: I11549e298eafae1ae5bd5f745c1421ba5eb1c584
---
M wikipedia/res/values/dev_settings_strings.xml
M wikipedia/res/xml/developer_preferences.xml
2 files changed, 29 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/87/223987/1
diff --git a/wikipedia/res/values/dev_settings_strings.xml
b/wikipedia/res/values/dev_settings_strings.xml
index f0c9e1f..3a3c14b 100644
--- a/wikipedia/res/values/dev_settings_strings.xml
+++ b/wikipedia/res/values/dev_settings_strings.xml
@@ -7,4 +7,5 @@
<string
name="menu_developer_settings">@string/developer_settings_activity_title</string>
<string name="preferences_developer_misc_heading">Miscellaneous</string>
<string name="preferences_developer_onboarding_heading">Onboarding</string>
+ <string name="preferences_developer_feature_testing_heading">A/B feature
testing</string>
</resources>
\ No newline at end of file
diff --git a/wikipedia/res/xml/developer_preferences.xml
b/wikipedia/res/xml/developer_preferences.xml
index af656a6..a2c9071 100644
--- a/wikipedia/res/xml/developer_preferences.xml
+++ b/wikipedia/res/xml/developer_preferences.xml
@@ -1,15 +1,33 @@
<?xml version="1.0" encoding="utf-8"?>
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android";>
+ <PreferenceCategory
android:title="@string/preferences_developer_feature_testing_heading">
+
+ <CheckBoxPreference
+
android:key="@string/preference_key_feature_select_text_and_share_tutorials_enabled"
+
android:title="@string/preference_key_feature_select_text_and_share_tutorials_enabled"
/>
+
+ <CheckBoxPreference
+ android:key="@string/preference_key_more_like_search_enabled"
+ android:title="@string/preference_key_more_like_search_enabled" />
+
+ <!--suppress AndroidUnknownAttribute -->
+ <org.wikipedia.settings.IntPreference
+ style="@style/IntPreference"
+ android:key="@string/preference_key_link_preview_version"
+ android:title="@string/preference_key_link_preview_version" />
+
+ <CheckBoxPreference
+ android:key="@string/preference_key_exp_page_load"
+ android:title="@string/preference_key_exp_page_load" />
+
+ </PreferenceCategory>
+
<PreferenceCategory
android:title="@string/preferences_developer_onboarding_heading">
<CheckBoxPreference
android:key="@string/preference_key_toc_tutorial_enabled"
android:title="@string/preference_key_toc_tutorial_enabled" />
-
- <CheckBoxPreference
-
android:key="@string/preference_key_feature_select_text_and_share_tutorials_enabled"
-
android:title="@string/preference_key_feature_select_text_and_share_tutorials_enabled"
/>
<CheckBoxPreference
android:key="@string/preference_key_select_text_tutorial_enabled"
@@ -23,42 +41,34 @@
<PreferenceCategory
android:title="@string/preferences_developer_misc_heading">
+ <!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.EditTextAutoSummarizePreference
style="@style/EditTextAutoSummarizePreference"
android:key="@string/preference_key_reading_app_install_id"
android:title="@string/preference_key_reading_app_install_id"
android:inputType="textVisiblePassword" />
+ <!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.IntPreference
style="@style/IntPreference"
android:key="@string/preference_key_login_user_id"
android:title="@string/preference_key_login_user_id" />
+ <!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.EditTextAutoSummarizePreference
style="@style/EditTextAutoSummarizePreference"
android:key="@string/preference_key_language"
android:title="@string/preference_key_language"
android:inputType="textVisiblePassword" />
+ <!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.EditTextAutoSummarizePreference
style="@style/EditTextAutoSummarizePreference"
android:key="@string/preference_key_language_mru"
android:title="@string/preference_key_language_mru"
android:inputType="textVisiblePassword" />
- <org.wikipedia.settings.IntPreference
- style="@style/IntPreference"
- android:key="@string/preference_key_link_preview_version"
- android:title="@string/preference_key_link_preview_version" />
-
- <CheckBoxPreference
- android:key="@string/preference_key_more_like_search_enabled"
- android:title="@string/preference_key_more_like_search_enabled" />
-
- <CheckBoxPreference
- android:key="@string/preference_key_exp_page_load"
- android:title="@string/preference_key_exp_page_load" />
-
+ <!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.LongPreference
style="@style/LongPreference"
android:key="@string/preference_key_last_daily_event_time"
@@ -70,4 +80,4 @@
</PreferenceCategory>
-</PreferenceScreen>
\ No newline at end of file
+</PreferenceScreen>
--
To view, visit https://gerrit.wikimedia.org/r/223987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11549e298eafae1ae5bd5f745c1421ba5eb1c584
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
