jenkins-bot has submitted this change and it was merged.
Change subject: Fix Client tests due to core change with IDatabase interface
......................................................................
Fix Client tests due to core change with IDatabase interface
Tests were broken due to commit with hash
5682eb48fa1efa64d34c8cfcc4afbb5079d4fc0c
and with changeid
Ia83530820f185415725c1d5f54b5172121b4938f
This change simply changes we way we mock
the IDatabase interface.
Change-Id: I0d8e939d0ad3cec7e7e2669c5bd5ed7bec01d670
---
M
client/tests/phpunit/includes/store/sql/ConsistentReadConnectionManagerTest.php
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Bene: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/client/tests/phpunit/includes/store/sql/ConsistentReadConnectionManagerTest.php
b/client/tests/phpunit/includes/store/sql/ConsistentReadConnectionManagerTest.php
index 2070700..6190ac9 100644
---
a/client/tests/phpunit/includes/store/sql/ConsistentReadConnectionManagerTest.php
+++
b/client/tests/phpunit/includes/store/sql/ConsistentReadConnectionManagerTest.php
@@ -17,11 +17,7 @@
class ConsistentReadConnectionManagerTest extends \PHPUnit_Framework_TestCase {
private function getConnectionMock() {
- $connection = $this->getMockBuilder( 'IDatabase' )
- ->setMethods( array( 'startAtomic', 'endAtomic',
'rollback' ) )
- ->getMock();
-
- return $connection;
+ return $this->getMock( 'IDatabase' );
}
private function getLoadBalancerMock() {
--
To view, visit https://gerrit.wikimedia.org/r/224043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d8e939d0ad3cec7e7e2669c5bd5ed7bec01d670
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
