Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224068
Change subject: Add destroyReferencesListview method to statementview
......................................................................
Add destroyReferencesListview method to statementview
This almost qualifies as a bug. Nothing bad happens if there is no clean
destruction, the worst it could do is wasting memory.
This is split from I9444ae5 to make it easier to review.
Bug: T87759
Change-Id: I797b4c4524e15f1b6d8a1e3aa3a0dd6984009eaf
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/68/224068/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 052890b..30dfca0 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -424,6 +424,7 @@
this.$mainSnak.off( '.' + this.widgetName );
this._destroyQualifiersListView();
+ this._destroyReferencesListview();
PARENT.prototype.destroy.call( this );
},
@@ -442,6 +443,19 @@
},
/**
+ * @private
+ */
+ _destroyReferencesListview: function() {
+ if( this._referencesListview ) {
+ this._referencesListview.destroy();
+ this.$references
+ .off( '.' + this.widgetName )
+ .empty();
+ this._referencesListview = null;
+ }
+ },
+
+ /**
* @inheritdoc
*/
draw: function() {
--
To view, visit https://gerrit.wikimedia.org/r/224068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I797b4c4524e15f1b6d8a1e3aa3a0dd6984009eaf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
