Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224074
Change subject: Add missing listview dependencies to toolbar controllers
......................................................................
Add missing listview dependencies to toolbar controllers
All these modules call methods that are declared in
jquery.wikibase.listview, e.g. listview.listItemAdapter(). The missing
dependency is not an actual problem becaus the dependency is already
loaded via the other dependencies. But it's better to have it explicit.
This is split from I9444ae5.
Bug: T87759
Change-Id: I8bb1301110467a4bed5d172855c940341fb7d57b
---
M view/resources/jquery/wikibase/toolbar/controller/resources.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/74/224074/1
diff --git a/view/resources/jquery/wikibase/toolbar/controller/resources.php
b/view/resources/jquery/wikibase/toolbar/controller/resources.php
index 723b69d..7362dc1 100644
--- a/view/resources/jquery/wikibase/toolbar/controller/resources.php
+++ b/view/resources/jquery/wikibase/toolbar/controller/resources.php
@@ -33,6 +33,7 @@
),
'dependencies' => array(
'jquery.wikibase.addtoolbar',
+ 'jquery.wikibase.listview',
'jquery.wikibase.statementlistview',
'jquery.wikibase.toolbarcontroller',
'wikibase.templates',
@@ -56,6 +57,7 @@
),
'dependencies' => array(
'jquery.wikibase.addtoolbar',
+ 'jquery.wikibase.listview',
'jquery.wikibase.statementview',
'jquery.wikibase.toolbarcontroller',
),
@@ -70,6 +72,7 @@
),
'dependencies' => array(
'jquery.wikibase.addtoolbar',
+ 'jquery.wikibase.listview',
'jquery.wikibase.statementview',
'jquery.wikibase.toolbarcontroller',
),
@@ -129,6 +132,7 @@
'definitions/removetoolbar/referenceview-snakview.js',
),
'dependencies' => array(
+ 'jquery.wikibase.listview',
'jquery.wikibase.referenceview',
'jquery.wikibase.removetoolbar',
'jquery.wikibase.toolbarcontroller',
@@ -151,6 +155,7 @@
'definitions/removetoolbar/statementview-snakview.js',
),
'dependencies' => array(
+ 'jquery.wikibase.listview',
'jquery.wikibase.removetoolbar',
'jquery.wikibase.statementview',
'jquery.wikibase.toolbarcontroller',
--
To view, visit https://gerrit.wikimedia.org/r/224074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bb1301110467a4bed5d172855c940341fb7d57b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
