Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/224381

Change subject: Use correct format to register VisualEditor commands
......................................................................

Use correct format to register VisualEditor commands

args and supportedSelections are in the same object, not
in separate objects.

This ensures the mention button is disabled and grayed out
when the selection leaves the editor, just like the other
toolbar buttons.

Change-Id: I88aa2e12ccd98ba2786ab39038b0553bf83a0c91
---
M modules/editor/editors/visualeditor/mw.flow.ve.CommandRegistry.js
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/81/224381/1

diff --git a/modules/editor/editors/visualeditor/mw.flow.ve.CommandRegistry.js 
b/modules/editor/editors/visualeditor/mw.flow.ve.CommandRegistry.js
index 6552668..4a6ba6a 100644
--- a/modules/editor/editors/visualeditor/mw.flow.ve.CommandRegistry.js
+++ b/modules/editor/editors/visualeditor/mw.flow.ve.CommandRegistry.js
@@ -6,8 +6,7 @@
                        'flowMention',
                        'window',
                        'open',
-                       { args: [ 'flowMention' ] },
-                       { supportedSelections: [ 'linear' ] }
+                       { args: [ 'flowMention' ], supportedSelections: [ 
'linear' ] }
                )
        );
 
@@ -16,8 +15,7 @@
                        'flowMentionAt',
                        'window',
                        'open',
-                       { args: [ 'flowMention', { selectAt: true } ] },
-                       { supportedSelections: [ 'linear' ] }
+                       { args: [ 'flowMention', { selectAt: true } ], 
supportedSelections: [ 'linear' ] }
                )
        );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/224381
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88aa2e12ccd98ba2786ab39038b0553bf83a0c91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to