Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224403
Change subject: Remove listeners from deprecated search widget 'select' events
......................................................................
Remove listeners from deprecated search widget 'select' events
Attach listeners to search *result* widget 'choose' events instead.
Depends on I8a9b7dda in VE.
Change-Id: I8a908f3a7ab4e5b7c4de7bb0bc91500c1072d56e
---
M modules/ve.ui.CiteFromIdInspector.js
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid
refs/changes/03/224403/1
diff --git a/modules/ve.ui.CiteFromIdInspector.js
b/modules/ve.ui.CiteFromIdInspector.js
index cfb7c65..042d7f2 100644
--- a/modules/ve.ui.CiteFromIdInspector.js
+++ b/modules/ve.ui.CiteFromIdInspector.js
@@ -214,7 +214,7 @@
this.lookupButton.connect( this, { click: 'onLookupButtonClick' } );
this.previewSelectWidget.connect( this, { choose:
'onPreviewSelectWidgetChoose' } );
this.sourceSelect.connect( this, { choose: 'onSourceSelectChoose' } );
- this.search.connect( this, { select: 'onSearchSelect' } );
+ this.search.getResults().connect( this, { choose:
'onSearchResultsChoose' } );
this.autoProcessStack.addItems( [
this.autoProcessPanels.lookup,
@@ -309,15 +309,15 @@
};
/**
- * Handle search select events.
+ * Handle search results choose events.
*
- * @param {ve.dm.MWReferenceModel|null} ref Reference model or null if no item
is selected
+ * @param {ve.dm.MWReferenceResultWidget} item Chosen item
*/
-ve.ui.CiteFromIdInspector.prototype.onSearchSelect = function ( ref ) {
- if ( ref instanceof ve.dm.MWReferenceModel ) {
- ref.insertReferenceNode( this.getFragment() );
- this.getFragment().getSurface().applyStaging();
- }
+ve.ui.CiteFromIdInspector.prototype.onSearchResultsChoose = function ( item ) {
+ var ref = item.getData();
+
+ ref.insertReferenceNode( this.getFragment() );
+ this.getFragment().getSurface().applyStaging();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/224403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a908f3a7ab4e5b7c4de7bb0bc91500c1072d56e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
