jenkins-bot has submitted this change and it was merged.
Change subject: ToCWidget: Remove wrapper div
......................................................................
ToCWidget: Remove wrapper div
We don't need it any more. It doesn't have an overflow rule
any more, and the position: absolute;, width: 100%; and
max-height rules can be applied to the NavigationWidget instead.
Change-Id: Ifbfe02f1abd82e3df0c292710355013deccc34d5
---
M modules/flow/ui/widgets/mw.flow.ui.ToCWidget.js
M modules/styles/flow/widgets/mw.flow.ui.NavigationWidget.less
2 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Mooeypoo: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/flow/ui/widgets/mw.flow.ui.ToCWidget.js
b/modules/flow/ui/widgets/mw.flow.ui.ToCWidget.js
index 9365da3..6a21cfc 100644
--- a/modules/flow/ui/widgets/mw.flow.ui.ToCWidget.js
+++ b/modules/flow/ui/widgets/mw.flow.ui.ToCWidget.js
@@ -32,9 +32,6 @@
widget: this.button
} );
- this.$wrapper = $( '<div>' )
- .addClass( 'flow-ui-tocWidget-wrapper' );
-
// Events
this.topicSelect.connect( this, { topic: 'onTopicSelectTopic' }
);
this.button.connect( this, { click: 'onButtonClick' } );
@@ -44,7 +41,7 @@
.addClass( 'flow-ui-tocWidget' )
.append(
this.button.$element,
- this.$wrapper.append( this.topicSelect.$element
)
+ this.topicSelect.$element
);
};
diff --git a/modules/styles/flow/widgets/mw.flow.ui.NavigationWidget.less
b/modules/styles/flow/widgets/mw.flow.ui.NavigationWidget.less
index 5075932..95404bc 100644
--- a/modules/styles/flow/widgets/mw.flow.ui.NavigationWidget.less
+++ b/modules/styles/flow/widgets/mw.flow.ui.NavigationWidget.less
@@ -43,7 +43,7 @@
}
}
- &-wrapper {
+ .flow-ui-topicMenuSelectWidget {
position: absolute;
width: 100%;
max-height: 400px;
--
To view, visit https://gerrit.wikimedia.org/r/223731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbfe02f1abd82e3df0c292710355013deccc34d5
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
