Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224635
Change subject: Convert spaces to tabs in CheckResultToViolationTranslator.php
......................................................................
Convert spaces to tabs in CheckResultToViolationTranslator.php
Change-Id: I4035ffbada44f21c579312701a12632ff696cba0
---
M includes/Violations/CheckResultToViolationTranslator.php
1 file changed, 47 insertions(+), 43 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/35/224635/1
diff --git a/includes/Violations/CheckResultToViolationTranslator.php
b/includes/Violations/CheckResultToViolationTranslator.php
index a9397b8..ffafdca 100644
--- a/includes/Violations/CheckResultToViolationTranslator.php
+++ b/includes/Violations/CheckResultToViolationTranslator.php
@@ -2,33 +2,32 @@
namespace WikibaseQuality\ConstraintReport\Violations;
+use InvalidArgumentException;
use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\Lib\Store\EntityRevisionLookup;
use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult;
use WikibaseQuality\Violations\Violation;
-use InvalidArgumentException;
-
class CheckResultToViolationTranslator {
- /**
- * @var EntityRevisionLookup
- */
- private $entityRevisionLookup;
+ /**
+ * @var EntityRevisionLookup
+ */
+ private $entityRevisionLookup;
- /**
- * @param EntityRevisionLookup $entityRevisionLookup
- */
- public function __construct( EntityRevisionLookup $entityRevisionLookup ) {
- $this->entityRevisionLookup = $entityRevisionLookup;
- }
+ /**
+ * @param EntityRevisionLookup $entityRevisionLookup
+ */
+ public function __construct( EntityRevisionLookup $entityRevisionLookup
) {
+ $this->entityRevisionLookup = $entityRevisionLookup;
+ }
public function translateToViolation( Entity $entity,
$checkResultOrArray ) {
- $checkResultArray = $this->setCheckResultArray( $checkResultOrArray
);
+ $checkResultArray = $this->setCheckResultArray(
$checkResultOrArray );
- $violationArray = array ();
+ $violationArray = array();
foreach ( $checkResultArray as $checkResult ) {
if ( $checkResult->getStatus() !==
CheckResult::STATUS_VIOLATION ) {
continue;
@@ -40,48 +39,53 @@
$entityId = $entity->getId();
//TODO: Use real claimGuid
$constraintTypeEntityId =
$checkResult->getConstraintName();
- $constraintId = $this->setConstraintId( $checkResult, $statement,
$constraintTypeEntityId );
+ $constraintId =
+ $this->setConstraintId( $checkResult,
$statement, $constraintTypeEntityId );
$revisionId =
$this->entityRevisionLookup->getLatestRevisionId( $entityId );
$status = CheckResult::STATUS_VIOLATION;
- $constraintParameters = $checkResult->getParameters();
+ $constraintParameters = $checkResult->getParameters();
- $additionalInfo = array();
+ $additionalInfo = array();
- if ( array_key_exists( 'constraint_status', $constraintParameters
)) {
- $additionalInfo['constraint_status'] =
$constraintParameters['constraint_status'];
- }
+ if ( array_key_exists( 'constraint_status',
$constraintParameters ) ) {
+ $additionalInfo['constraint_status'] =
$constraintParameters['constraint_status'];
+ }
- $violationArray[ ] = new Violation( $entityId, $propertyId,
$claimGuid, $constraintId, $constraintTypeEntityId, $revisionId, $status,
$additionalInfo );
+ $violationArray[] =
+ new Violation( $entityId, $propertyId,
$claimGuid, $constraintId, $constraintTypeEntityId, $revisionId, $status,
$additionalInfo );
}
return $violationArray;
}
- /**
- * @param CheckResult|CheckResult[] $checkResultOrArray
- * @return CheckResult[]
- */
- private function setCheckResultArray( $checkResultOrArray ){
+ /**
+ * @param CheckResult|CheckResult[] $checkResultOrArray
+ *
+ * @return CheckResult[]
+ */
+ private function setCheckResultArray( $checkResultOrArray ) {
- if ( $checkResultOrArray instanceof CheckResult ) {
- return array ( $checkResultOrArray );
- } elseif ( is_array( $checkResultOrArray ) ) {
- return $checkResultOrArray;
- }
+ if ( $checkResultOrArray instanceof CheckResult ) {
+ return array( $checkResultOrArray );
+ } elseif ( is_array( $checkResultOrArray ) ) {
+ return $checkResultOrArray;
+ }
- throw new InvalidArgumentException;
- }
+ throw new InvalidArgumentException;
+ }
- private function setConstraintId( CheckResult $checkResult, Statement
$statement, $constraintTypeEntityId ){
- $constraintId = $statement->getGuid() . $constraintTypeEntityId;
- $parameters = $checkResult->getParameters();
- if ( is_array( $parameters ) ) {
- foreach ( $parameters as $par ) {
- $constraintId .= implode( ', ', $par );
- }
- }
+ private function setConstraintId( CheckResult $checkResult,
+ Statement $statement,
+ $constraintTypeEntityId ) {
+ $constraintId = $statement->getGuid() . $constraintTypeEntityId;
+ $parameters = $checkResult->getParameters();
+ if ( is_array( $parameters ) ) {
+ foreach ( $parameters as $par ) {
+ $constraintId .= implode( ', ', $par );
+ }
+ }
- return WBQ_CONSTRAINTS_ID. Violation::CONSTRAINT_ID_DELIMITER .
$constraintId;
- }
+ return WBQ_CONSTRAINTS_ID . Violation::CONSTRAINT_ID_DELIMITER
. $constraintId;
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/224635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4035ffbada44f21c579312701a12632ff696cba0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
