jenkins-bot has submitted this change and it was merged. Change subject: Exclude auto-generated files from PHPCS' LineLength sniff ......................................................................
Exclude auto-generated files from PHPCS' LineLength sniff As mentioned in https://gerrit.wikimedia.org/r/#/c/223016/2/client/WikibaseClient.i18n.magic.php Change-Id: I113502fa3903271974d7de5618b78dc73aa2f46b --- M client/WikibaseClient.i18n.magic.php M phpcs.xml 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/client/WikibaseClient.i18n.magic.php b/client/WikibaseClient.i18n.magic.php index ac62caf..ddfb492 100644 --- a/client/WikibaseClient.i18n.magic.php +++ b/client/WikibaseClient.i18n.magic.php @@ -85,11 +85,7 @@ /** Hindi (हिन्दी) */ $magicWords['hi'] = array( - 'noexternallanglinks' => array( - 0, - 'कोई_अंतरविकी_कड़ियाँ_नहीं', - 'कोई_अंतरविकि_कड़ियाँ_नहीं' - ), + 'noexternallanglinks' => array( 0, 'कोई_अंतरविकी_कड़ियाँ_नहीं', 'कोई_अंतरविकि_कड़ियाँ_नहीं' ), 'property' => array( 0, 'गुण' ), ); diff --git a/phpcs.xml b/phpcs.xml index e08e01b..1d56ec3 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -13,10 +13,12 @@ <rule ref="Generic.Files.LineEndings" /> <rule ref="Generic.Files.LineLength"> <properties> - <!-- FIXME: Should be decreased to 100, preferably in steps of 10. --> + <!-- TODO: Should be decreased to 100, preferably in steps of 10. --> <property name="lineLimit" value="170" /> <property name="absoluteLineLimit" value="9999" /> </properties> + <!-- Exclude auto-generated file from the Translate extension, see magic-export.php.--> + <exclude-pattern>\.i18n\.magic\.php</exclude-pattern> </rule> <rule ref="Generic.Files.OneInterfacePerFile" /> <rule ref="Generic.Files.OneTraitPerFile" /> @@ -55,7 +57,7 @@ <rule ref="Squiz.Classes.ValidClassName.NotCamelCaps"> <!-- FIXME: This indicates an error in the Wikibase codebase that should be fixed. --> - <exclude-pattern>DataAccess*Scribunto*Scribunto_LuaWikibase*Library</exclude-pattern> + <exclude-pattern>DataAccess*Scribunto*Scribunto_LuaWikibase*Library*\.php</exclude-pattern> </rule> <rule ref="Squiz.ControlStructures.ControlSignature" /> <!-- FIXME: This indicates an error in the Wikibase codebase that should be fixed. --> -- To view, visit https://gerrit.wikimedia.org/r/224857 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113502fa3903271974d7de5618b78dc73aa2f46b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
