Eranroz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/225022
Change subject: Avoid (safe) exception by using empty options
......................................................................
Avoid (safe) exception by using empty options
Using try-catch block to handle common case of empty options isn't nice.
Avoid it be replacing options to valid JSON
Change-Id: I5b64f7f9a76a94d9c07face8059beab59d4aef93
---
M resources/js/ext.uls.preferences.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/22/225022/1
diff --git a/resources/js/ext.uls.preferences.js
b/resources/js/ext.uls.preferences.js
index 0229e01..36f96d2 100644
--- a/resources/js/ext.uls.preferences.js
+++ b/resources/js/ext.uls.preferences.js
@@ -101,7 +101,9 @@
this.preferences = preferenceStore().get(
this.preferenceName );
} else {
var options = mw.user.options.get(
this.preferenceName );
-
+ if ( !options ) {
+ options = '{}';
+ }
// Try to parse JSON
try {
this.preferences = JSON.parse( options
);
--
To view, visit https://gerrit.wikimedia.org/r/225022
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b64f7f9a76a94d9c07face8059beab59d4aef93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Eranroz <eranro...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
