Aaron Schulz has submitted this change and it was merged.

Change subject: (bug 42483) Avoid serializing database object in update.php
......................................................................


(bug 42483) Avoid serializing database object in update.php

Change I96b4cfd4 changed the data being stored in updatelog, trying to
store the mangled parameters (which may included an added copy of the
DatabaseUpdater object itself) instead of the input parameters. This
causes warnings because database objects cannot be effectively
serialized.

Go back to storing the original input parameters instead.

Change-Id: I96e6dffed98772ebb9b812773ff2f608e7e40cb1
---
M includes/installer/DatabaseUpdater.php
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  Aude: Looks good to me, but someone else must approve
  MarkAHershberger: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/36609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96e6dffed98772ebb9b812773ff2f608e7e40cb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Asher <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: DaSch <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: MarkAHershberger <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to