Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/225280

Change subject: Remove obsolete VCL code for setting X-Analytics: https=1
......................................................................

Remove obsolete VCL code for setting X-Analytics: https=1

This serves no purpose now that we're HTTPS-only.

Change-Id: Ic643a3a9bd0e592f91449b36ca259336ef4a267e
---
M templates/varnish/text-frontend.inc.vcl.erb
1 file changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/80/225280/1

diff --git a/templates/varnish/text-frontend.inc.vcl.erb 
b/templates/varnish/text-frontend.inc.vcl.erb
index a1e3dcf..95f40cb 100644
--- a/templates/varnish/text-frontend.inc.vcl.erb
+++ b/templates/varnish/text-frontend.inc.vcl.erb
@@ -175,17 +175,6 @@
        }
 <% end -%>
 
-       // Assemble X-Analytics header
-       // Some of the headers used for X-Analytics are not varied on, so add 
them after the backend processing
-       // Note that vcl_deliver in other files may also modify X-Analytics.
-       if (req.http.X-Forwarded-Proto) {
-               if (resp.http.X-Analytics) {
-                       set resp.http.X-Analytics = resp.http.X-Analytics + 
";https=1";
-               } else {
-                       set resp.http.X-Analytics = "https=1";
-               }
-       }
-
        if (req.http.X-WMF-UUID) {
                if (resp.http.X-Analytics) {
                        set resp.http.X-Analytics = resp.http.X-Analytics + 
";wmfuuid=" + req.http.X-WMF-UUID;

-- 
To view, visit https://gerrit.wikimedia.org/r/225280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic643a3a9bd0e592f91449b36ca259336ef4a267e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to