Kaldari has submitted this change and it was merged. Change subject: Remove dependency on E3Experiments for clicktracking ......................................................................
Remove dependency on E3Experiments for clicktracking E3Experiments had to be installed to use .stall functionality, to ensure that en event would not be propagated before completing the clicktracking call, which is async by default. The dependency on E3Experiments is no longer desirable, as AFT will need to run on wiki's that do not have E3Experiments enabled (in this case: dewiki). Another (even safer) approach has now been implemented to ensure that an event does not propagate before the clicktracking call is completed: making the call syncronous! Change-Id: I8da7da4b697f63df66fe5f8eb6866d6c49e636dc --- M ArticleFeedbackv5.hooks.php M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.talk.js M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.watchlist.js M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.track.js 7 files changed, 111 insertions(+), 71 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36730 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8da7da4b697f63df66fe5f8eb6866d6c49e636dc Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Matthias Mullie <[email protected]> Gerrit-Reviewer: Demon <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
