Alex Monk has submitted this change and it was merged.
Change subject: Replace jquery.json dependency with JSON polyfill
......................................................................
Replace jquery.json dependency with JSON polyfill
...and move the dependency to the right module.
Change-Id: Ia71aaef9f59d0ed3c40ed79c9e255b0688c78a87
---
M Gadgets.php
M modules/ext.gadgets.api.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alex Monk: Verified; Looks good to me, approved
diff --git a/Gadgets.php b/Gadgets.php
index 9cecc03..04a9a2a 100644
--- a/Gadgets.php
+++ b/Gadgets.php
@@ -205,6 +205,7 @@
'mediawiki.Title',
'mediawiki.util',
'mediawiki.api',
+ 'json',
'user.tokens',
),
),
@@ -223,7 +224,6 @@
'jquery.ui.autocomplete',
'jquery.ui.dialog',
'jquery.createPropCloud',
- 'jquery.json',
'jquery.spinner',
'mediawiki.Title',
'mediawiki.util',
diff --git a/modules/ext.gadgets.api.js b/modules/ext.gadgets.api.js
index 0e6477e..9018f6d 100644
--- a/modules/ext.gadgets.api.js
+++ b/modules/ext.gadgets.api.js
@@ -255,7 +255,7 @@
query = {
action: 'edit',
title: t.getPrefixedDb(),
- text: $.toJSON( gadget.metadata
),
+ text: JSON.stringify(
gadget.metadata ),
summary: mw.msg(
'gadgetmanager-comment-modify', gadget.id ),
token: mw.user.tokens.get(
'editToken' )
};
--
To view, visit https://gerrit.wikimedia.org/r/225369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia71aaef9f59d0ed3c40ed79c9e255b0688c78a87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: RL2
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
