Sumit has uploaded a new change for review. https://gerrit.wikimedia.org/r/225855
Change subject: WikidataPageBanner allow spaces in banner href ...................................................................... WikidataPageBanner allow spaces in banner href Bug: T106321 Change-Id: Iaae97116ed93877ac12eb3935380eedb3a50ae52 --- M templates/banner.mustache 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner refs/changes/55/225855/1 diff --git a/templates/banner.mustache b/templates/banner.mustache index fb37c81..997d11d 100644 --- a/templates/banner.mustache +++ b/templates/banner.mustache @@ -2,7 +2,7 @@ <div class="ext-wpb-pagebanner"> <div class="wpb-topbanner"> <div class="wpb-name">{{title}}</div> - <a title="{{tooltip}}" href={{bannerfile}}><img src={{banner}} srcset="{{srcset}}" class="wpb-banner-image"></a> + <a title="{{tooltip}}" href="{{bannerfile}}"><img src={{banner}} srcset="{{srcset}}" class="wpb-banner-image"></a> {{#hasIcons}} <div class="wpb-iconbox"> {{#icons}} -- To view, visit https://gerrit.wikimedia.org/r/225855 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaae97116ed93877ac12eb3935380eedb3a50ae52 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikidataPageBanner Gerrit-Branch: master Gerrit-Owner: Sumit <asthana.sumi...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits