Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226255
Change subject: mw.widgets.TitleInputWidget: Don't bypass namespace choice with
redirects
......................................................................
mw.widgets.TitleInputWidget: Don't bypass namespace choice with redirects
If 'namespace' was not null, and 'showRedirectTargets' was true (the default),
pages from namespaces other than the chosen one could appear in the
suggestions when a cross-namespace redirect from chosen to other namespace
was encountered. Prevent this.
Change-Id: Id863d002d598dc2429919e88dd2dde9e9836bb3d
---
M resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/55/226255/1
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
index a9e4384..66b009f 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js
@@ -201,7 +201,12 @@
imageUrl: OO.getProp( suggestionPage,
'thumbnail', 'source' ),
description: OO.getProp( suggestionPage,
'terms', 'description' )
};
- titles.push( suggestionPage.title );
+
+ // Throw away pages from wrong namespaces. This can
happen when 'showRedirectTargets' is true
+ // and we encounter a cross-namespace redirect.
+ if ( this.namespace === null || this.namespace ===
suggestionPage.ns ) {
+ titles.push( suggestionPage.title );
+ }
redirects = redirectsTo[suggestionPage.title] || [];
for ( i = 0, len = redirects.length; i < len; i++ ) {
--
To view, visit https://gerrit.wikimedia.org/r/226255
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id863d002d598dc2429919e88dd2dde9e9836bb3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
