[MediaWiki-commits] [Gerrit] Remove more unused stuff from LibSerializerFactory - change (mediawiki...Wikibase)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/226514

Change subject: Remove more unused stuff from LibSerializerFactory
......................................................................

Remove more unused stuff from LibSerializerFactory

Change-Id: I9060a28bb1c3fb7e8711bd4c42ec2ca29598bf46
---
M lib/includes/serializers/LibSerializerFactory.php
1 file changed, 8 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/14/226514/1

diff --git a/lib/includes/serializers/LibSerializerFactory.php 
b/lib/includes/serializers/LibSerializerFactory.php
index 62ce80f..29208f1 100644
--- a/lib/includes/serializers/LibSerializerFactory.php
+++ b/lib/includes/serializers/LibSerializerFactory.php
@@ -3,15 +3,10 @@
 namespace Wikibase\Lib\Serializers;
 
 use InvalidArgumentException;
-use OutOfBoundsException;
 use SiteStore;
-use Wikibase\DataModel\Claim\Claim;
-use Wikibase\DataModel\Claim\Claims;
 use Wikibase\DataModel\Entity\Item;
 use Wikibase\DataModel\Entity\Property;
 use Wikibase\DataModel\Entity\PropertyDataTypeLookup;
-use Wikibase\DataModel\Reference;
-use Wikibase\DataModel\Snak\Snak;
 use Wikibase\EntityFactory;
 
 /**
@@ -30,17 +25,17 @@
        /**
         * @var EntityFactory|null
         */
-       public $entityFactory = null;
+       private $entityFactory = null;
 
        /**
         * @var SiteStore|null
         */
-       public $siteStore = null;
+       private $siteStore = null;
 
        /**
         * @var PropertyDataTypeLookup|null
         */
-       protected $dataTypeLookup = null;
+       private $dataTypeLookup = null;
 
        /**
         * @param SerializationOptions $defaultOptions
@@ -118,15 +113,6 @@
         *
         * @return Serializer
         */
-       public function newReferenceSerializer( SerializationOptions $options ) 
{
-               return new ReferenceSerializer( $this->newSnakSerializer( 
$options ), $options );
-       }
-
-       /**
-        * @param SerializationOptions $options
-        *
-        * @return Serializer
-        */
        public function newClaimSerializer( SerializationOptions $options ) {
                return new ClaimSerializer( $this->newSnakSerializer( $options 
), $options );
        }
@@ -145,7 +131,7 @@
         *
         * @return Serializer
         */
-       public function newItemSerializer( SerializationOptions $options ) {
+       private function newItemSerializer( SerializationOptions $options ) {
                return new ItemSerializer( $this->newClaimSerializer( $options 
), $this->siteStore, $options, $this->entityFactory );
        }
 
@@ -154,26 +140,8 @@
         *
         * @return Serializer
         */
-       public function newPropertySerializer( SerializationOptions $options ) {
+       private function newPropertySerializer( SerializationOptions $options ) 
{
                return new PropertySerializer( $this->newClaimSerializer( 
$options ), $options, $this->entityFactory );
-       }
-
-       /**
-        * @param SerializationOptions $options
-        *
-        * @return Serializer
-        */
-       public function newAliasSerializer( SerializationOptions $options ) {
-               return new AliasSerializer( $this->makeOptions( $options ) );
-       }
-
-       /**
-        * @param SerializationOptions $options
-        *
-        * @return Unserializer
-        */
-       public function newReferenceUnserializer( SerializationOptions $options 
) {
-               return $this->newReferenceSerializer( $this->makeOptions( 
$options ) );
        }
 
        /**
@@ -190,7 +158,7 @@
         *
         * @return Unserializer
         */
-       public function newItemUnserializer( SerializationOptions $options ) {
+       private function newItemUnserializer( SerializationOptions $options ) {
                return $this->newItemSerializer( $this->makeOptions( $options ) 
);
        }
 
@@ -199,7 +167,7 @@
         *
         * @return Unserializer
         */
-       public function newPropertyUnserializer( SerializationOptions $options 
) {
+       private function newPropertyUnserializer( SerializationOptions $options 
) {
                return $this->newPropertySerializer( $this->makeOptions( 
$options ) );
        }
 
@@ -211,7 +179,7 @@
         *
         * @return null|SerializationOptions
         */
-       protected function makeOptions( SerializationOptions $options = null ) {
+       private function makeOptions( SerializationOptions $options = null ) {
                if ( $options === null && $this->defaultOptions === null ) {
                        return new SerializationOptions();
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/226514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9060a28bb1c3fb7e8711bd4c42ec2ca29598bf46
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits