Mobrovac has submitted this change and it was merged.
Change subject: Minor: do not check body against the RegEx
......................................................................
Minor: do not check body against the RegEx
Grpahoid sends out binary blobs, which often cannot be UTF-decoded, thus
producing false negatives for the monitoring utility. Furthermore,
checking binary data against a RegEx is not really a sane thing to do,
so drop the body: /.+/ check. We can still rely on the response code and
Content-Type header checks to detect anomalies.
Change-Id: I22c97261c339013309e1ae11e6be9881d7c20978
---
M spec.yaml
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Mobrovac: Verified; Looks good to me, approved
diff --git a/spec.yaml b/spec.yaml
index 1c71292..7e39dcd 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -74,4 +74,3 @@
status: 200
headers:
content-type: image/png
- body: /.+/
--
To view, visit https://gerrit.wikimedia.org/r/226523
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22c97261c339013309e1ae11e6be9881d7c20978
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/graphoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
