EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226593
Change subject: Enable TestSearchSatisfaction schema for anon users
......................................................................
Enable TestSearchSatisfaction schema for anon users
The patch creating ext.wikimediaEvents module has been live long
enough we are now safe to push this out and serve the schema to
all users.
Change-Id: Id1a32dec8f48b5ec9a78687732408bfe4c2fe3b1
(cherry picked from commit 08be6ca93144d0a2d8cb52377aa7321a4fcdae02)
---
M WikimediaEvents.php
M modules/ext.wikimediaEvents.search.js
2 files changed, 5 insertions(+), 10 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/93/226593/1
diff --git a/WikimediaEvents.php b/WikimediaEvents.php
index 0f804d9..6771582 100644
--- a/WikimediaEvents.php
+++ b/WikimediaEvents.php
@@ -76,6 +76,9 @@
'scripts' => array(
'ext.wikimediaEvents.resourceloader.js',
),
+ 'dependencies' => array(
+ 'ext.wikimediaEvents.search',
+ ),
'localBasePath' => __DIR__ . '/modules',
'remoteExtPath' => 'WikimediaEvents/modules',
'targets' => array( 'desktop', 'mobile' ),
@@ -113,10 +116,7 @@
'localBasePath' => __DIR__ . '/modules',
'remoteExtPath' => 'WikimediaEvents/modules',
'targets' => array( 'desktop', 'mobile' ),
- 'dependencies' => array(
- 'mediawiki.Uri',
- 'mediawiki.user',
- ),
+ 'dependencies' => 'mediawiki.Uri',
),
'schema.GeoFeatures' => array(
'class' => 'ResourceLoaderSchemaModule',
diff --git a/modules/ext.wikimediaEvents.search.js
b/modules/ext.wikimediaEvents.search.js
index 2abb666..1d701a0 100644
--- a/modules/ext.wikimediaEvents.search.js
+++ b/modules/ext.wikimediaEvents.search.js
@@ -20,12 +20,6 @@
// code uses sendBeacon, so limit event collection to browsers
with
// sendBeacon.
!navigator.sendBeacon ||
- // the ext.wikimediaEvents resourceloader module needs to be
deployed
- // for at least 30 days to make into the varnish cache of
article pages
- // before we can reliably collect data from anon users. Remove
this
- // after those 30 days are up and shift the mediawiki.user
dependency down
- // below.
- mw.user.isAnon() ||
// If a non integer value was provided in the searchDepth query
parameter
// just give up tracking at this point. That non-integer
probably didn't
// come from us anyways.
@@ -36,6 +30,7 @@
mw.loader.using( [
'jquery.jStorage',
+ 'mediawiki.user',
'ext.eventLogging',
'schema.TestSearchSatisfaction'
] ).then( function () {
--
To view, visit https://gerrit.wikimedia.org/r/226593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1a32dec8f48b5ec9a78687732408bfe4c2fe3b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.26wmf15
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
