Fjalapeno has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226625
Change subject: Fix crash for nil title while saving page
......................................................................
Fix crash for nil title while saving page
Bug: T106028
Bail out early in production
Add an assert for debugging
Change-Id: Ifcd49fa511aaa22e89a5d050abaf86a855718aff
---
M Wikipedia/View Controllers/WebView/WebViewController.m
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/25/226625/1
diff --git a/Wikipedia/View Controllers/WebView/WebViewController.m
b/Wikipedia/View Controllers/WebView/WebViewController.m
index da8259f..4c93c59 100644
--- a/Wikipedia/View Controllers/WebView/WebViewController.m
+++ b/Wikipedia/View Controllers/WebView/WebViewController.m
@@ -994,6 +994,11 @@
}
- (void)showPageSavedAlertMessageForTitle:(NSString*)title {
+ NSParameterAssert(title);
+ if ([title length] == 0) {
+ return;
+ }
+
// First show saved message.
NSString* savedMessage = MWLocalizedString(@"share-menu-page-saved", nil);
--
To view, visit https://gerrit.wikimedia.org/r/226625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcd49fa511aaa22e89a5d050abaf86a855718aff
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
