Yaron Koren has submitted this change and it was merged.
Change subject: Fix for 07f9ec1 - added needed check
......................................................................
Fix for 07f9ec1 - added needed check
Change-Id: Iae44cdb3b99d32437823361e4847efda95e5b5ba
---
M CargoSQLQuery.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Yaron Koren: Checked; Looks good to me, approved
diff --git a/CargoSQLQuery.php b/CargoSQLQuery.php
index ca112fc..5b1820c 100644
--- a/CargoSQLQuery.php
+++ b/CargoSQLQuery.php
@@ -441,7 +441,9 @@
// If we couldn't find a table name,
// throw an error.
- throw new MWException( "Error: no field
named \"$fieldName\" found for any of the specified database tables." );
+ if ( $tableName == '' ) {
+ throw new MWException( "Error:
no field named \"$fieldName\" found for any of the specified database tables."
);
+ }
}
}
// Fix alias.
--
To view, visit https://gerrit.wikimedia.org/r/226633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae44cdb3b99d32437823361e4847efda95e5b5ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
