jenkins-bot has submitted this change and it was merged.

Change subject: Fix statsd role permission issue
......................................................................


Fix statsd role permission issue

Use o+r instead of group to ensure www-data can read
/vagrant/srv/statsd/config.js
Group would not work as /vagrant/srv is shared with the host
and operations requiring root are unreliable.

Change-Id: I04357ed3b5d91a049b013d08a3c5753415e77935
---
M puppet/modules/statsd/manifests/init.pp
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/modules/statsd/manifests/init.pp 
b/puppet/modules/statsd/manifests/init.pp
index 068b5f9..d80fe97 100644
--- a/puppet/modules/statsd/manifests/init.pp
+++ b/puppet/modules/statsd/manifests/init.pp
@@ -28,9 +28,8 @@
 
     file { "${dir}/config.js":
         ensure  => present,
-        group   => 'www-data',
         content => template('statsd/config.js.erb'),
-        mode    => '0640',
+        mode    => '0644',
         require => Git::Clone['statsd'],
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/226628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04357ed3b5d91a049b013d08a3c5753415e77935
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: GergÅ‘ Tisza <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Dduvall <[email protected]>
Gerrit-Reviewer: GergÅ‘ Tisza <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to