Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: contint: pin tox to version 1.9.2
......................................................................
contint: pin tox to version 1.9.2
With T46443 we have python tox installed using the puppet 'pip'
provider and ensure => present.
I guess that installs whatever latest version is available in pipy, so
we want to pin it to a specific version. Looking at puppet code, it
seems we can pass the version to the ensure parameters.
Currently all slaves have 1.9.2, so ensure 1.9.2 instead of present.
Puppet runs:
Debug: Executing '/usr/bin/pip install -q tox==1.9.2'
Notice: /Stage[main]/Contint::Packages::Labs/Package[tox]/ensure: created
Bug: T106799
Change-Id: If4a12931146b04078b12f7f891f32e35d4ffcdd8
---
M modules/contint/manifests/packages/labs.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
Hashar: Verified; Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/contint/manifests/packages/labs.pp
b/modules/contint/manifests/packages/labs.pp
index a773773..951e017 100644
--- a/modules/contint/manifests/packages/labs.pp
+++ b/modules/contint/manifests/packages/labs.pp
@@ -109,7 +109,7 @@
# TODO: Reevaluate this once we switch to trusty. Maybe provider being apt
# would be better then
package { 'tox':
- ensure => present,
+ ensure => '1.9.2',
provider => 'pip',
require => Package['python-pip'],
}
--
To view, visit https://gerrit.wikimedia.org/r/226694
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4a12931146b04078b12f7f891f32e35d4ffcdd8
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
