Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: contint: fully qualify unix command
......................................................................
contint: fully qualify unix command
54b111324 added some exec commands that missed the full paths causing
puppet error:
Failed to apply catalog: Parameter unless failed on Exec[jenkins-deploy
kvm membership]: 'grep -q 'kvm\S*jenkins-deploy' /etc/group' is not
qualified and no path was specified. Please qualify the command or
specify a path. at
/etc/puppet/modules/contint/manifests/packages/labs.pp:158
Fully qualify the commands:
grep -> /bin/grep
usermod -> /usr/sbin/usermod
Bug: T62720
Change-Id: I79ab5fc5ca0075ef9f388954c325631d1acd6951
---
M modules/contint/manifests/packages/labs.pp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Giuseppe Lavagetto: Verified; Looks good to me, approved
diff --git a/modules/contint/manifests/packages/labs.pp
b/modules/contint/manifests/packages/labs.pp
index 951e017..92e3455 100644
--- a/modules/contint/manifests/packages/labs.pp
+++ b/modules/contint/manifests/packages/labs.pp
@@ -152,8 +152,8 @@
}
exec {"jenkins-deploy kvm membership":
- unless => "grep -q 'kvm\\S*jenkins-deploy' /etc/group",
- command => "usermod -aG kvm jenkins-deploy",
+ unless => "/bin/grep -q 'kvm\\S*jenkins-deploy' /etc/group",
+ command => "/usr/sbin/usermod -aG kvm jenkins-deploy",
require => User['jenkins-deploy'],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/226696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79ab5fc5ca0075ef9f388954c325631d1acd6951
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
