Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: contint: drop require to a user in LDAP
......................................................................
contint: drop require to a user in LDAP
The puppet requirement upon a User in LDAP does not work:
require => User['jenkins-deploy']
Drop the requirement, the actual command will just fail if the user can
not be found via LDAP.
Bug: T62720
Change-Id: Ie29a4572eccdc025def46a5b38e22480ca49cd4e
---
M modules/contint/manifests/packages/labs.pp
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/contint/manifests/packages/labs.pp
b/modules/contint/manifests/packages/labs.pp
index 92e3455..00025eb 100644
--- a/modules/contint/manifests/packages/labs.pp
+++ b/modules/contint/manifests/packages/labs.pp
@@ -154,7 +154,6 @@
exec {"jenkins-deploy kvm membership":
unless => "/bin/grep -q 'kvm\\S*jenkins-deploy' /etc/group",
command => "/usr/sbin/usermod -aG kvm jenkins-deploy",
- require => User['jenkins-deploy'],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/226698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie29a4572eccdc025def46a5b38e22480ca49cd4e
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
