Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226906
Change subject: Only change edit link if the current text is as expected
......................................................................
Only change edit link if the current text is as expected
Otherwise we end up colliding with other extensions like Translate
Bug: T94386
Change-Id: Ib48ce33b8db9639400415cf778cd42e2d47070f1
---
M extension.json
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/06/226906/1
diff --git a/extension.json b/extension.json
index a6d5d83..c900197 100644
--- a/extension.json
+++ b/extension.json
@@ -262,7 +262,8 @@
"visualeditor-ca-editsource-section",
"postedit-confirmation-created",
"postedit-confirmation-restored",
- "postedit-confirmation-saved"
+ "postedit-confirmation-saved",
+ "edit"
],
"position": "top"
},
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 12cec86..daccd2e 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -352,7 +352,7 @@
$caEditLink.text( mw.msg(
tabMessages[action + 'localdescriptionsource'] ) );
}
} else {
- if ( tabMessages[action + 'source'] !== null ) {
+ if ( tabMessages[action + 'source'] !== null &&
$caEditLink.text() === mw.msg( 'edit' ) ) {
$caEditLink.text( mw.msg(
tabMessages[action + 'source'] ) );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/226906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib48ce33b8db9639400415cf778cd42e2d47070f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
