Mholloway has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226908
Change subject: Increase page refresh spinner offset by 16dp
......................................................................
Increase page refresh spinner offset by 16dp
Per Google UX review recommendations.
Bug: T105088
Change-Id: Id725672613c3166c7cd0a44cbc81c794048cca22
---
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/08/226908/1
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
index 2fffa76..d03e46c 100755
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
@@ -83,6 +83,7 @@
public static final int SUBSTATE_SAVED_PAGE_LOADED = 2;
private static final int TOC_BUTTON_HIDE_DELAY = 2000;
+ private static final int REFRESH_SPINNER_ADDL_OFFSET = (int) (16 *
WikipediaApp.getInstance().getScreenDensity());
private PageLoadStrategy pageLoadStrategy = null;
private PageViewModel model;
@@ -208,7 +209,7 @@
refreshView = (SwipeRefreshLayoutWithScroll) rootView
.findViewById(R.id.page_refresh_container);
- int swipeOffset = Utils.getActionBarSize(getActivity());
+ int swipeOffset = Utils.getActionBarSize(getActivity()) +
REFRESH_SPINNER_ADDL_OFFSET;
refreshView.setProgressViewOffset(true, -swipeOffset, swipeOffset);
refreshView.setSize(SwipeRefreshLayout.LARGE);
// if we want to give it a custom color:
--
To view, visit https://gerrit.wikimedia.org/r/226908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id725672613c3166c7cd0a44cbc81c794048cca22
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
