Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226914
Change subject: Update WikidataPageBanner tests
......................................................................
Update WikidataPageBanner tests
Change-Id: Ic5dc68507876e62e823c1ca2950bc3b5b40257da
---
A .jshintrc
M Gruntfile.js
M composer.json
M package.json
A phpcs.xml
5 files changed, 56 insertions(+), 22 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/14/226914/1
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..82721ad
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,19 @@
+{
+ // Enforcing
+ "bitwise": true,
+ "eqeqeq": true,
+ "freeze": true,
+ "latedef": true,
+ "noarg": true,
+ "nonew": true,
+ "undef": true,
+ "unused": false,
+ "strict": false,
+
+ // Relaxing
+ "es5": false,
+
+ // Environment
+ "browser": true,
+ "jquery": true
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index dba7fa6..07a141e 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,22 +1,28 @@
module.exports = function ( grunt ) {
- grunt.loadNpmTasks( 'grunt-banana-checker' );
- grunt.loadNpmTasks( 'grunt-contrib-jshint' );
+ grunt.loadNpmTasks( 'grunt-contrib-jshint' );
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ grunt.initConfig( {
+ jshint: {
+ options: {
+ jshintrc: true
+ },
+ all: [
+ '*.js'
+ ]
+ },
+ banana: {
+ all: 'i18n/'
+ },
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**'
+ ]
+ }
+ } );
- grunt.initConfig( {
- jshint: {
- options: {
- jshintrc: true
- },
- all: [
- 'Gruntfile.js',
- 'resources',
- ],
- },
- banana: {
- all: 'i18n/'
- },
- } );
-
- grunt.registerTask( 'test', [ 'jshint', 'banana' ] );
- grunt.registerTask( 'default', 'test' );
+ grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
};
diff --git a/composer.json b/composer.json
index 7dd4cd9..6bc638e 100644
--- a/composer.json
+++ b/composer.json
@@ -14,7 +14,7 @@
"scripts": {
"test": [
"parallel-lint . --exclude vendor",
- "phpcs
--standard=vendor/mediawiki/mediawiki-codesniffer/MediaWiki
--extensions=php,php5,inc --ignore=vendor -p ."
+ "phpcs -p"
]
}
}
diff --git a/package.json b/package.json
index c14a4cb..3924b79 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,9 @@
"devDependencies": {
"grunt": "0.4.5",
"grunt-cli": "0.1.13",
- "grunt-banana-checker": "0.2.1",
- "grunt-contrib-jshint": "0.11.2"
+ "grunt-contrib-jshint": "0.11.2",
+ "grunt-banana-checker": "0.2.2",
+ "grunt-jscs": "1.8.0",
+ "grunt-jsonlint": "1.0.4"
}
}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..cb19440
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0"?>
+<ruleset>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <file>.</file>
+ <arg name="extensions" value="php"/>
+ <exclude-pattern>vendor</exclude-pattern>
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/226914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5dc68507876e62e823c1ca2950bc3b5b40257da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
