Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226930
Change subject: Adjust how position-fixed works in light of new beta
......................................................................
Adjust how position-fixed works in light of new beta
Since all drawers/overlays get added to the viewport/body tag they
do not belong to either the content area so it's not possible to distinguish
whether the overlay/drawer should be shifted when the menu is open. Since this
only seems to be a problem for the search overlay - now the only overlay you
can open from the left menu let's limit these rules to drawers for the time
being.
Bug: T106434
Change-Id: Iec5659107f120939efb9e07607bb063ad6ea4012
---
M resources/mobile.mainMenu/mainmenu.less
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/30/226930/1
diff --git a/resources/mobile.mainMenu/mainmenu.less
b/resources/mobile.mainMenu/mainmenu.less
index c9ad98b..02985a8 100644
--- a/resources/mobile.mainMenu/mainmenu.less
+++ b/resources/mobile.mainMenu/mainmenu.less
@@ -184,7 +184,8 @@
width: @menuWidth;
}
- .position-fixed {
+ // FIXME: Menu shouldn't need to know about drawers but a cta drawer
might be open
+ .drawer .position-fixed {
left: @menuWidth !important;
}
}
@@ -248,14 +249,16 @@
.navigation-enabled.animations {
- .position-fixed,
+ // FIXME: Menu shouldn't need to know about drawers but a cta drawer
might be open
+ .drawer .position-fixed,
#mw-mf-page-center {
.transition-transform(@duration @easing);
}
}
.primary-navigation-enabled.animations {
- .position-fixed,
+ // FIXME: Menu shouldn't need to know about drawers
+ .drawer .position-fixed,
#mw-mf-page-center {
// override non-animated version
left: 0 !important;
@@ -291,7 +294,8 @@
}
&.primary-navigation-enabled.animations {
- .position-fixed,
+ // FIXME: Menu shouldn't need to know about drawers
+ .drawer .position-fixed,
#mw-mf-page-center {
.transform(translate(-@menuWidth, 0));
}
--
To view, visit https://gerrit.wikimedia.org/r/226930
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec5659107f120939efb9e07607bb063ad6ea4012
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
