Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227167
Change subject: FormSpecialPage: You can't actually accept the HTMLForm
parameter in onSubmit()
......................................................................
FormSpecialPage: You can't actually accept the HTMLForm parameter in onSubmit()
It would be convenient if it was possible (for example, we could
remove ~20 lines of code in SpecialBlock, which work around this),
but it's not.
Fatal error: Declaration of SpecialWhatever::onSubmit() must be
compatible with FormSpecialPage::onSubmit(array $data)
Follow-up to 0188fe7d5eda87f40e1c5908aaa659bc8a7d5b4c.
Change-Id: Ib18fb7292a67b471e9ad13cf38038287b9bd2bd2
---
M includes/specialpage/FormSpecialPage.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/67/227167/1
diff --git a/includes/specialpage/FormSpecialPage.php
b/includes/specialpage/FormSpecialPage.php
index 42c5980..83f00d8 100644
--- a/includes/specialpage/FormSpecialPage.php
+++ b/includes/specialpage/FormSpecialPage.php
@@ -125,10 +125,9 @@
/**
* Process the form on POST submission.
* @param array $data
- * @param HTMLForm $form
* @return bool|string|array|Status As documented for
HTMLForm::trySubmit.
*/
- abstract public function onSubmit( array $data /* $form = null */ );
+ abstract public function onSubmit( array $data );
/**
* Do something exciting on successful processing of the form, most
likely to show a
--
To view, visit https://gerrit.wikimedia.org/r/227167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib18fb7292a67b471e9ad13cf38038287b9bd2bd2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
