Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227186
Change subject: Allow to add a link by pressing enter from the link inspector
......................................................................
Allow to add a link by pressing enter from the link inspector
When a page is selected to be added as a link, the user needs to
press a button to complete the link creation.
Allow to trigger that action by pressing enter too for keyboard-only users.
Bug: T106441
Change-Id: I1f6e1dfb89814697043df8cd3415d80578bee4f9
---
M modules/tools/ext.cx.tools.link.js
M modules/widgets/pageselector/ext.cx.pageselector.js
2 files changed, 11 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/86/227186/1
diff --git a/modules/tools/ext.cx.tools.link.js
b/modules/tools/ext.cx.tools.link.js
index edcaa43..54f457a 100644
--- a/modules/tools/ext.cx.tools.link.js
+++ b/modules/tools/ext.cx.tools.link.js
@@ -912,6 +912,7 @@
* @return {jQuery}
*/
LinkerTool.prototype.getCard = function () {
+ var self = this;
this.$pageSelectorButton = $( '<button>' )
.prop( 'disabled', true )
.addClass( 'mw-ui-button mw-ui-progressive' )
@@ -948,7 +949,10 @@
this.$targetPageSelector = new mw.PageSelector(
this.$searchInput, {
api: mw.cx.siteMapper.getApi( mw.cx.targetLanguage ),
- showMissingPage: true
+ showMissingPage: true,
+ onSelect: function ( selectedPage ) {
+ self.createLink( selectedPage, 'internal' );
+ }
} );
return this.$card;
diff --git a/modules/widgets/pageselector/ext.cx.pageselector.js
b/modules/widgets/pageselector/ext.cx.pageselector.js
index 6821140..ef70272 100644
--- a/modules/widgets/pageselector/ext.cx.pageselector.js
+++ b/modules/widgets/pageselector/ext.cx.pageselector.js
@@ -244,6 +244,9 @@
if ( event.keyCode === 13 ) {
// Enter key handler
self.hide();
+ if ( self.options.onSelect ) {
+ self.options.onSelect.call( self,
self.getSelectedPage() );
+ }
return false;
}
} );
@@ -257,6 +260,8 @@
// Example: mw.Api( { ajax: { url: apiURL } } )
api: new mw.Api(),
// Show a missing page if search did not return any page.
- showMissingPage: false
+ showMissingPage: false,
+ // Callback when a page is selected
+ onSelect: null
};
}( jQuery, mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/227186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f6e1dfb89814697043df8cd3415d80578bee4f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
