jenkins-bot has submitted this change and it was merged.
Change subject: Fixes counting of references
......................................................................
Fixes counting of references
Fixes counting of references by filtering on class 'wb-reference-new'
instead of items with value.
Bug: T98593
Change-Id: I7bbcd9142b4e6e64e112f8e9cd67dad0a8714b53
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 30dfca0..ff7e451 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -626,8 +626,8 @@
numberOfPendingValues = 0;
if( this._referencesListview ) {
- numberOfValues =
this._referencesListview.nonEmptyItems().length;
- numberOfPendingValues =
this._referencesListview.items().length - numberOfValues;
+ numberOfPendingValues =
this._referencesListview.items().filter( '.wb-reference-new' ).length;
+ numberOfValues =
this._referencesListview.items().length - numberOfPendingValues;
}
// build a nice counter, displaying fixed and pending values:
--
To view, visit https://gerrit.wikimedia.org/r/227230
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bbcd9142b4e6e64e112f8e9cd67dad0a8714b53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Bene <benestar.wikime...@gmail.com>
Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
