Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227415
Change subject: WikidataPageBanner check avoid empty icons
......................................................................
WikidataPageBanner check avoid empty icons
Excess commas may lead to empty icon generation. Check for empty icon name and
avoid adding any such icon.
Bug: T107133
Change-Id: I63ec901acd049f62f0797a9e57d401232e6dc495
---
M includes/WikidataPageBanner.functions.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/15/227415/1
diff --git a/includes/WikidataPageBanner.functions.php
b/includes/WikidataPageBanner.functions.php
index 2fda70e..dff4785 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -26,6 +26,9 @@
if ( isset( $argumentsFromParserFunction['icons'] ) ) {
$icons = explode( ',',
$argumentsFromParserFunction['icons'] );
foreach ( $icons as $iconname ) {
+ if ( empty( $iconname ) ) {
+ continue;
+ }
$iconName = Sanitizer::escapeClass( $iconname );
$icon = new OOUI\IconWidget( array(
'icon' => $iconName,
--
To view, visit https://gerrit.wikimedia.org/r/227415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63ec901acd049f62f0797a9e57d401232e6dc495
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
