Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227459
Change subject: Remove LibSerializer from ParserOutputJsConfigBuilderTest
......................................................................
Remove LibSerializer from ParserOutputJsConfigBuilderTest
This might be the last usage :O
Change-Id: Icdcfc7352c5cf08b080afa95dbec2e6203ae9a1b
---
M repo/tests/phpunit/includes/ParserOutputJsConfigBuilderTest.php
1 file changed, 3 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/59/227459/1
diff --git a/repo/tests/phpunit/includes/ParserOutputJsConfigBuilderTest.php
b/repo/tests/phpunit/includes/ParserOutputJsConfigBuilderTest.php
index 5cb79f2..5f56fa5 100644
--- a/repo/tests/phpunit/includes/ParserOutputJsConfigBuilderTest.php
+++ b/repo/tests/phpunit/includes/ParserOutputJsConfigBuilderTest.php
@@ -9,9 +9,8 @@
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Snak\PropertyValueSnak;
-use Wikibase\Lib\Serializers\SerializationOptions;
-use Wikibase\Lib\Serializers\LibSerializerFactory;
use Wikibase\ParserOutputJsConfigBuilder;
+use Wikibase\Repo\WikibaseRepo;
/**
* @covers Wikibase\ParserOutputJsConfigBuilder
@@ -42,11 +41,8 @@
}
public function assertSerializationEqualsEntity( Entity $entity,
$serialization ) {
- $serializerFactory = new LibSerializerFactory();
- $options = new SerializationOptions();
-
- $unserializer = $serializerFactory->newUnserializerForEntity(
$entity->getType(), $options );
- $unserializedEntity = $unserializer->newFromSerialization(
$serialization );
+ $deserializer =
WikibaseRepo::getDefaultInstance()->getEntityDeserializer();
+ $unserializedEntity = $deserializer->deserialize(
$serialization );
$this->assertTrue( $unserializedEntity->equals( $entity ),
'unserialized entity equals entity' );
}
--
To view, visit https://gerrit.wikimedia.org/r/227459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icdcfc7352c5cf08b080afa95dbec2e6203ae9a1b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
