jenkins-bot has submitted this change and it was merged.
Change subject: WikidataPageBanner check for invalid Property name
......................................................................
WikidataPageBanner check for invalid Property name
Return null from getWikidataBanner() if banner property is empty. Fix
description of getWikidataBanner().
Bug: T107001
Change-Id: Iade85972f384c2644a4b27e6bce76079c6a2697d
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index dea3058..c284aa6 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -254,12 +254,15 @@
* Fetches banner from wikidata for the specified page
*
* @param Title $title Title of the page
- * @return String|null file name of the banner from wikitata
[description]
+ * @return String|null file name of the banner from wikidata
* or null if none found
*/
public static function getWikidataBanner( $title ) {
global $wgBannerProperty;
$banner = null;
+ if ( empty( $wgBannerProperty ) ) {
+ return null;
+ }
// Ensure Wikibase client is installed
if ( class_exists( 'Wikibase\Client\WikibaseClient' ) ) {
$entityIdLookup =
Wikibase\Client\WikibaseClient::getDefaultInstance()
--
To view, visit https://gerrit.wikimedia.org/r/227176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iade85972f384c2644a4b27e6bce76079c6a2697d
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Sumit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
