jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused $value parameter from getErrorMessage
......................................................................
Remove unused $value parameter from getErrorMessage
Was only used to pass the credit card number in, which we don't do.
Change-Id: Iba7fc313acbc7a7d99258933f8abb59e646dbaf8
---
M gateway_common/DataValidator.php
1 file changed, 1 insertion(+), 9 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_common/DataValidator.php b/gateway_common/DataValidator.php
index 4558177..12db4c0 100644
--- a/gateway_common/DataValidator.php
+++ b/gateway_common/DataValidator.php
@@ -92,11 +92,9 @@
* 'calculated' - fields that failed some kind of multiple-field
data
* integrity check.
* @param string $language MediaWiki language code
- * @param string $value - The value of the field. So far, only used to
say
- * more precise things about Credit Cards.
* @return String
*/
- public static function getErrorMessage( $field, $type, $language,
$value = null ){
+ public static function getErrorMessage( $field, $type, $language ){
//this is gonna get ugly up in here.
//error_log( __FUNCTION__ . " $field, $type, $value " );
@@ -134,12 +132,6 @@
switch ($token){
case 'amount':
$suffix = 'invalid-amount';
- break;
- case 'card_num': //god damn it.
- $suffix = 'card_num'; //more
defaultness.
- if (!is_null($value)){
- $suffix =
self::getCardType($value);
- }
break;
}
--
To view, visit https://gerrit.wikimedia.org/r/227511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba7fc313acbc7a7d99258933f8abb59e646dbaf8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
